-
Notifications
You must be signed in to change notification settings - Fork 184
Introduce basic support for close_read and close_write.
#743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good to me for TLS 1.3 connections. I'm wondering if
|
|
IMHO, I think it's better just to do nothing. Raising an error will be more trouble for the user, and of little value. In other words, no other implementation of |
8769853 to
9ff95ba
Compare
|
I don't see how Could you add some rdoc comments on the behavior difference? |
9ff95ba to
c8377ea
Compare
|
What do you think of the updated documentation? |
|
@rhenium thanks for your detailed review. Can you check it again? |
|
Looks good to me. Thank you! |
Introduce
SSLSocket#close_readandSSLSocket#close_write+ relevant test.#close_readis a no-op and exists to match the expected interface ofIO.#close_writeuses#stopwhich in testing appears to do what we want.Fixes #609.