Skip to content

🐛 Fix inconsistently frozen SequenceSet#[] result #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/net/imap/sequence_set.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1242,16 +1242,16 @@ def slice_range(range)
first = range.begin || 0
last = range.end || -1
if range.exclude_end?
return SequenceSet.empty if last.zero?
return remain_frozen_empty if last.zero?
last -= 1 if range.end && last != STAR_INT
end
if (first * last).positive? && last < first
SequenceSet.empty
remain_frozen_empty
elsif (min = at(first))
max = at(last)
if max == :* then self & (min..)
elsif min <= max then self & (min..max)
else SequenceSet.empty
else remain_frozen_empty
end
end
end
Expand Down Expand Up @@ -1391,6 +1391,7 @@ def init_with(coder) # :nodoc:
private

def remain_frozen(set) frozen? ? set.freeze : set end
def remain_frozen_empty; frozen? ? SequenceSet.empty : SequenceSet.new end

# frozen clones are shallow copied
def initialize_clone(other)
Expand Down
26 changes: 26 additions & 0 deletions test/net/imap/test_sequence_set.rb
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,32 @@ def compare_to_reference_set(nums, set, seqset)
end
end

data "#slice(length)", {transform: ->{ _1.slice(0, 10) }, }
data "#slice(range)", {transform: ->{ _1.slice(0...10) }, }
data "#slice => empty", {transform: ->{ _1.slice(0...0) }, }
data "#slice => empty", {transform: ->{ _1.slice(10..9) }, }
data "#union", {transform: ->{ _1 | (1..100) }, }
data "#intersection", {transform: ->{ _1 & (1..100) }, }
data "#difference", {transform: ->{ _1 - (1..100) }, }
# data "#xor", {transform: ->{ _1 ^ (1..100) }, }
data "#complement", {transform: ->{ ~_1 }, }
data "#normalize", {transform: ->{ _1.normalize }, }
data "#limit", {transform: ->{ _1.limit(max: 22) }, freeze: :always }
data "#limit => empty", {transform: ->{ _1.limit(max: 1) }, freeze: :always }
test "transforms keep frozen status" do |data|
data => {transform:}
set = SequenceSet.new("2:4,7:11,99,999")
result = transform.to_proc.(set)
if data in {freeze: :always}
assert result.frozen?, "this transform always returns frozen"
else
refute result.frozen?, "transform of non-frozen returned frozen"
end
set.freeze
result = transform.to_proc.(set)
assert result.frozen?, "transform of frozen returned non-frozen"
end

%i[clone dup].each do |method|
test "##{method}" do
orig = SequenceSet.new "2:4,7:11,99,999"
Expand Down