🥅 Work around missing server responses #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By converting all of the internal `@responses.delete(type)` to `clear_responses(type)`, we get empty arrays and don't need nil-checks. Fixes #190.
nevans
added a commit
that referenced
this pull request
Oct 5, 2023
`#fetch` returns an empty array, rather than nil, since #192.
nevans
added a commit
that referenced
this pull request
Oct 6, 2023
`#fetch` returns an empty array, rather than nil, since #192.
philippks
added a commit
to hitobito/hitobito
that referenced
this pull request
Aug 21, 2025
As described [here](ruby/net-imap#192), some imap functions now return an empty array and not anymore `nil`. This is also the case for the used function `uid_fetch`. Now, we check correctly for `.blank?` instead of `.nil?`. I didn't find other occurences where the changed API has an impact.
carlobeltrame
pushed a commit
to hitobito/hitobito
that referenced
this pull request
Aug 22, 2025
As described [here](ruby/net-imap#192), some imap functions now return an empty array and not anymore `nil`. This is also the case for the used function `uid_fetch`. Now, we check correctly for `.blank?` instead of `.nil?`. I didn't find other occurences where the changed API has an impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By converting all of the internal
@responses.delete(type)toclear_responses(type), we get empty arrays and don't need nil-checks.n.b: this will result in some methods sometimes returning an empty array when they previously would have returned nil:
list,xlist,getquota,lsub,expunge,uid_expunge,fetch,uid_fetch,store, anduid_store.