Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ruby/net-http
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.0
Choose a base ref
...
head repository: ruby/net-http
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.6.0
Choose a head ref
  • 14 commits
  • 3 files changed
  • 4 contributors

Commits on Nov 14, 2024

  1. Allow Net::HTTP#request to raise Net::OpenTimeout (#12062)

    with a TCPSoerver that is only listening
    to avoid AssertionFailedError on Ubuntu.
    
    ---
    
    The tests such as
    `TestNetHTTP_v1_2_chunked#test_timeout_during_non_chunked_streamed_HTTP_session_write`
    expect to raise a `Net::WriteTimeout` due to a failure in writing to the server.
    
    However, on Ubuntu environments,
    the server immediately returns a "Connection Refused" in such cases.
    The socket created with `TCPSocket.new` that supports HEv2 catches this immediately
    and raises a `Net::OpenTimeout`.
    As a result, these tests fail due to raising a different exception than expected.
    This PR adds `Net::OpenTimeout` asexceptions to avoid these test failures.
    shioimm authored and hsbt committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d81eabf View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Remove deprecated constants

    These constants, isolated in net/http/backward.rb, have not only been
    deprecated since 2001, but have also had a warning since 2021.
    nobu committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    265bfa9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #189 from nobu/remove-deprecated-constants

    Remove deprecated constants
    nobu authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    71f8f24 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Bump step-security/harden-runner from 2.10.1 to 2.10.2

    Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.10.1 to 2.10.2.
    - [Release notes](https://github.com/step-security/harden-runner/releases)
    - [Commits](step-security/harden-runner@91182cc...0080882)
    
    ---
    updated-dependencies:
    - dependency-name: step-security/harden-runner
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9e25c12 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #190 from ruby/dependabot/github_actions/step-secu…

    …rity/harden-runner-2.10.2
    
    Bump step-security/harden-runner from 2.10.1 to 2.10.2
    hsbt authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3a83e46 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    37f17d2 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #191 from ruby/restore-http-session

    Restore HTTPSession constant for backward compatibility
    hsbt authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9949c06 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4650f86 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #192 from ruby/fixup-GH-191

    Need to restore under the Net namespace
    hsbt authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d18ab3d View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Do not wait connection attempt delay without in progress fds (#12087)

    Do not wait Connection Attempt Delay without in progress fds
    
    Reset Connection Attempt Delay when connection fails and there is no other socket connection in progress.
    This is intended to resolve an issue that was temporarily worked around in Pull Request #12062.
    
    `TCPServer::new` (used in tests such as `TestNetHTTP_v1_2_chunked#test_timeout_during_non_chunked_streamed_HTTP_session_write`) can only connect over either IPv6 or IPv4, depending on the environment.
    Since HEv2 attempts to connect over IPv6 first, environments where IPv6 connections are unavailable return ECONNREFUSED immediately.
    In such cases, the client should immediately retry the connection over IPv4.
    However, HEv2 includes a specification for a "Connection Attempt Delay," where it waits 250ms after the previous connection attempt before starting the next one.
    This delay causes Net::OpenTimeout (100ms) to be exceeded while waiting for the next connection attempt to start.
    
    With this change, when a connection attempt fails, if there are sockets still attempting to connect and there are addresses yet to be tried, the Connection Attempt Delay will be resetted, allowing the next connection attempt to start immediately.
    
    ---
    
    Additionally, the following minor fixes have been made:
    
    - The `nfds` value used for select(2) is now reset with each wait.
    shioimm authored and hsbt committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    cfbbb50 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Bump rubygems/release-gem

    Bumps [rubygems/release-gem](https://github.com/rubygems/release-gem) from 612653d273a73bdae1df8453e090060bb4db5f31 to 9e85cb11501bebc2ae661c1500176316d3987059.
    - [Release notes](https://github.com/rubygems/release-gem/releases)
    - [Commits](rubygems/release-gem@612653d...9e85cb1)
    
    ---
    updated-dependencies:
    - dependency-name: rubygems/release-gem
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    3e9654f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #196 from ruby/dependabot/github_actions/rubygems/…

    …release-gem-9e85cb11501bebc2ae661c1500176316d3987059
    
    Bump rubygems/release-gem from 612653d273a73bdae1df8453e090060bb4db5f31 to 9e85cb11501bebc2ae661c1500176316d3987059
    hsbt authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    3c7596b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4adf58c View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Bump up 0.6.0

    hsbt committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6475fa6 View commit details
    Browse the repository at this point in the history
Loading