Use ruby/actions workflow for ruby versions#136
Open
m-nakamura145 wants to merge 3 commits intoruby:masterfrom
Open
Use ruby/actions workflow for ruby versions#136m-nakamura145 wants to merge 3 commits intoruby:masterfrom
m-nakamura145 wants to merge 3 commits intoruby:masterfrom
Conversation
.github/workflows/ci.yml
Outdated
| with: | ||
| engine: cruby | ||
| min_version: 2.5 | ||
| versions: "[debug]" |
Contributor
There was a problem hiding this comment.
Perhaps like this:
Suggested change
| versions: "[debug]" | |
| versions: | |
| - debug |
...or perhaps it's called head, not debug?
Member
There was a problem hiding this comment.
It seems that we can't use JSON array here...: https://github.com/ruby/fiddle/actions/runs/7472168103/workflow
The workflow is not valid. .github/workflows/ci.yml (Line: 14, Col: 9): A sequence was not expected
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
Member
|
We may need to add a condition for fiddle/.github/workflows/ci.yml Line 51 in fd4bb4e BTW, do we need both of |
Member
|
Could you rebase on master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR has been changed to use the ruby/actions workflow for ruby versions.