Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ruby/did_you_mean
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.6.1
Choose a base ref
...
head repository: ruby/did_you_mean
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.6.2
Choose a head ref
  • 17 commits
  • 20 files changed
  • 7 contributors

Commits on Jan 3, 2022

  1. Configuration menu
    Copy the full SHA
    4e12c04 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Fix frozen_string_literal is ignored after any tokens warning. (#172)

    ```
    did_you_mean/formatters/verbose_formatter.rb:5: warning: `frozen_string_literal' is ignored after any tokens
    ```
    casperisfine authored Jan 21, 2022
    Configuration menu
    Copy the full SHA
    531760f View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. Added dependabot

    hsbt committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    20f2662 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #173 from ruby/add-dependabot

    Added dependabot.yml for actions
    hsbt authored Mar 25, 2022
    Configuration menu
    Copy the full SHA
    e63de6a View commit details
    Browse the repository at this point in the history
  3. Bump actions/checkout from 1 to 3

    Bumps [actions/checkout](https://github.com/actions/checkout) from 1 to 3.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@v1...v3)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Mar 25, 2022
    Configuration menu
    Copy the full SHA
    4a8de91 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #174 from ruby/dependabot/github_actions/actions/c…

    …heckout-3
    
    Bump actions/checkout from 1 to 3
    hsbt authored Mar 25, 2022
    Configuration menu
    Copy the full SHA
    80c74fe View commit details
    Browse the repository at this point in the history

Commits on May 21, 2022

  1. Configuration menu
    Copy the full SHA
    c3fc412 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. Define Exception#detailed_message instead of clobbering #message

    This changeset lets DidYouMean::Correctable to use #detailed_message,
    which is Ruby 3.2's more dedicated way to show additional error
    information like did_you_mean and error_highlight.
    
    There are some problems with the approach of overriding #message.
    One is that the approach breaks a test that checks a return value
    of #message. I actually faced this kind of issues in real-world
    applications when I was implementing error_highlight with the same
    approach as did_you_mean.
    See minitest/minitest#880 for example.
    
    For this reason, error_highlight enhances only NameError.
    The support of other error types such as TypeError and ArgumentError is
    currently disabled because it breaks more tests:
    https://github.com/ruby/error_highlight/blob/f88b6fab2ff34559a0f08d019d574dbb52426a20/lib/error_highlight/core_ext.rb#L49-L52
    
    I believe #detailed_message will solve the issue.
    I want did_you_mean and error_highlight to use the new API instead of
    clobbering #message method.
    See https://bugs.ruby-lang.org/issues/18564 for detail.
    mame committed May 23, 2022
    Configuration menu
    Copy the full SHA
    62799d7 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Merge pull request #177 from mame/use-detailed_message

    Define Exception#detailed_message instead of clobbering #message
    yuki24 authored May 24, 2022
    Configuration menu
    Copy the full SHA
    0b1942b View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Manually merge ruby/ruby@4146fd2

    hsbt committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    e6ab330 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03dc051 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Added sync task and sync them

    hsbt committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    97da3e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f02a9a0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f954f4 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #178 from ruby/assert-ractor

    Use assert_ractor in `test_ractor_compatible.rb`
    hsbt authored Sep 1, 2022
    Configuration menu
    Copy the full SHA
    9dce63d View commit details
    Browse the repository at this point in the history
  5. Merge pull request #176 from makketagg/fix/variable-name-corrections-…

    …duplicates
    
    Fixed correction duplicates in VaribaleNameChecker
    hsbt authored Sep 1, 2022
    Configuration menu
    Copy the full SHA
    c629aef View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Bump version to 1.6.2

    hsbt committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    f5b1512 View commit details
    Browse the repository at this point in the history
Loading