-
Notifications
You must be signed in to change notification settings - Fork 113
Comparing changes
Open a pull request
base repository: ruby/did_you_mean
base: v1.6.1
head repository: ruby/did_you_mean
compare: v1.6.2
- 17 commits
- 20 files changed
- 7 contributors
Commits on Jan 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4e12c04 - Browse repository at this point
Copy the full SHA 4e12c04View commit details
Commits on Jan 21, 2022
-
Fix
frozen_string_literal is ignored after any tokens
warning. (#172)``` did_you_mean/formatters/verbose_formatter.rb:5: warning: `frozen_string_literal' is ignored after any tokens ```
Configuration menu - View commit details
-
Copy full SHA for 531760f - Browse repository at this point
Copy the full SHA 531760fView commit details
Commits on Mar 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 20f2662 - Browse repository at this point
Copy the full SHA 20f2662View commit details -
Merge pull request #173 from ruby/add-dependabot
Added dependabot.yml for actions
Configuration menu - View commit details
-
Copy full SHA for e63de6a - Browse repository at this point
Copy the full SHA e63de6aView commit details -
Bump actions/checkout from 1 to 3
Bumps [actions/checkout](https://github.com/actions/checkout) from 1 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v1...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for 4a8de91 - Browse repository at this point
Copy the full SHA 4a8de91View commit details -
Merge pull request #174 from ruby/dependabot/github_actions/actions/c…
…heckout-3 Bump actions/checkout from 1 to 3
Configuration menu - View commit details
-
Copy full SHA for 80c74fe - Browse repository at this point
Copy the full SHA 80c74feView commit details
Commits on May 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c3fc412 - Browse repository at this point
Copy the full SHA c3fc412View commit details
Commits on May 23, 2022
-
Define Exception#detailed_message instead of clobbering #message
This changeset lets DidYouMean::Correctable to use #detailed_message, which is Ruby 3.2's more dedicated way to show additional error information like did_you_mean and error_highlight. There are some problems with the approach of overriding #message. One is that the approach breaks a test that checks a return value of #message. I actually faced this kind of issues in real-world applications when I was implementing error_highlight with the same approach as did_you_mean. See minitest/minitest#880 for example. For this reason, error_highlight enhances only NameError. The support of other error types such as TypeError and ArgumentError is currently disabled because it breaks more tests: https://github.com/ruby/error_highlight/blob/f88b6fab2ff34559a0f08d019d574dbb52426a20/lib/error_highlight/core_ext.rb#L49-L52 I believe #detailed_message will solve the issue. I want did_you_mean and error_highlight to use the new API instead of clobbering #message method. See https://bugs.ruby-lang.org/issues/18564 for detail.
Configuration menu - View commit details
-
Copy full SHA for 62799d7 - Browse repository at this point
Copy the full SHA 62799d7View commit details
Commits on May 24, 2022
-
Merge pull request #177 from mame/use-detailed_message
Define Exception#detailed_message instead of clobbering #message
Configuration menu - View commit details
-
Copy full SHA for 0b1942b - Browse repository at this point
Copy the full SHA 0b1942bView commit details
Commits on Jun 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e6ab330 - Browse repository at this point
Copy the full SHA e6ab330View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03dc051 - Browse repository at this point
Copy the full SHA 03dc051View commit details
Commits on Sep 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 97da3e1 - Browse repository at this point
Copy the full SHA 97da3e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f02a9a0 - Browse repository at this point
Copy the full SHA f02a9a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f954f4 - Browse repository at this point
Copy the full SHA 2f954f4View commit details -
Merge pull request #178 from ruby/assert-ractor
Use assert_ractor in `test_ractor_compatible.rb`
Configuration menu - View commit details
-
Copy full SHA for 9dce63d - Browse repository at this point
Copy the full SHA 9dce63dView commit details -
Merge pull request #176 from makketagg/fix/variable-name-corrections-…
…duplicates Fixed correction duplicates in VaribaleNameChecker
Configuration menu - View commit details
-
Copy full SHA for c629aef - Browse repository at this point
Copy the full SHA c629aefView commit details
Commits on Dec 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f5b1512 - Browse repository at this point
Copy the full SHA f5b1512View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.6.1...v1.6.2