Fix breakpoints' path option

It should distinguish if path is a string or a regexp and match them
with the path in different ways.

Author: st0012

lib/debug/breakpoint.rb

@@ -82,8 +82,11 @@ def duplicable?
     end
 
     def skip_path?(path)
-      if @path
+      case @path
+      when Regexp
         !path.match?(@path)
+      when String
+        !path.include?(@path)
       else
         super
       end

lib/debug/session.rb

@@ -1271,14 +1271,20 @@ def parse_break arg
         end
       }
       expr.default_proc = nil
-      expr.transform_values{|v| v.join(' ')}
+      expr = expr.transform_values{|v| v.join(' ')}
+
+      if (path = expr[:path]) && path =~ /\A\/(.*)\/\z/
+        expr[:path] = Regexp.compile($1)
+      end
+
+      expr
     end
 
     def repl_add_breakpoint arg
       expr = parse_break arg.strip
       cond = expr[:if]
       cmd = ['break', expr[:pre], expr[:do]] if expr[:pre] || expr[:do]
-      path = Regexp.compile(expr[:path]) if expr[:path]
+      path = expr[:path]
 
       case expr[:sig]
       when /\A(\d+)\z/
@@ -1301,7 +1307,7 @@ def repl_add_catch_breakpoint arg
       expr = parse_break arg.strip
       cond = expr[:if]
       cmd = ['catch', expr[:pre], expr[:do]] if expr[:pre] || expr[:do]
-      path = Regexp.compile(expr[:path]) if expr[:path]
+      path = expr[:path]
 
       bp = CatchBreakpoint.new(expr[:sig], cond: cond, command: cmd, path: path)
       add_bp bp

test/debug/break_test.rb

@@ -224,13 +224,34 @@ def program(extra_file_path)
       end
 
       def test_break_only_stops_when_path_matches
-        with_extra_tempfile do |extra_file|
+        with_extra_tempfile("foopy") do |extra_file|
+          # exact path match should work in both Regexp and String form
+          debug_code(program(extra_file.path)) do
+            type "break Foo#bar path: /#{extra_file.path}/"
+            type 'c'
+            assert_line_text(/#{extra_file.path}/)
+            type 'c'
+          end
+
           debug_code(program(extra_file.path)) do
             type "break Foo#bar path: #{extra_file.path}"
             type 'c'
             assert_line_text(/#{extra_file.path}/)
             type 'c'
           end
+
+          # special characters should be treated differently in Regexp/String form
+          debug_code(program(extra_file.path)) do
+            type "break Foo#bar path: /.py/"
+            type 'c'
+            assert_line_text(/#{extra_file.path}/)
+            type 'c'
+          end
+
+          debug_code(program(extra_file.path)) do
+            type "break Foo#bar path: .py"
+            type 'c'
+          end
         end
       end
 

test/support/test_case.rb

@@ -27,8 +27,10 @@ def remove_temp_file
       @temp_file = nil
     end
 
-    def with_extra_tempfile
-      t = Tempfile.create([SecureRandom.hex(5), '.rb']).tap do |f|
+    def with_extra_tempfile(*additional_words)
+      name = SecureRandom.hex(5) + additional_words.join
+
+      t = Tempfile.create([name, '.rb']).tap do |f|
         f.write(extra_file)
         f.close
       end