Skip to content

Commit 90bcdad

Browse files
committed
Don't wrap loop around waitpid call
Process.waitpid by default waits for its child to exit. So there's no need to wrap a loop around it. What happens in #485 is that the loop keeps running until it's killed by puma with a `KILL` signal. Reference: https://rubyapi.org/3.1/o/process#method-c-waitpid
1 parent bbc5831 commit 90bcdad

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/debug/local.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def after_fork_parent
9898
# only check child process from its parent
9999
begin
100100
# wait for all child processes to keep terminal
101-
loop{ Process.waitpid }
101+
Process.waitpid
102102
rescue Errno::ESRCH, Errno::ECHILD
103103
end
104104
end

0 commit comments

Comments
 (0)