Skip to content

Commit 7b062e6

Browse files
committed
DAP: need to wait for connection
At the breakpoint by `debugger()` method, the connection is needed and wait for the connection if it is not connected. With the fowllowing scenario, the debugger raises an exception becuase the connection is kept (but disconnection violate this assumption) 1. run the script includes `debugger` call 2. connect to DAP client 3. disconnect from DAP client 4. call `debugger` method To solve this issue, it needs to wait for the connection. `UI_ServerBase::sock` and `UI_ServerBase::readline` do it and we can use them on DAP connection, so remove `UI_DAP::sock` and `UI_DAP::readline`.
1 parent ceeeefa commit 7b062e6

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

lib/debug/server_dap.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -437,14 +437,6 @@ def process
437437

438438
## called by the SESSION thread
439439

440-
def readline prompt
441-
@q_msg.pop || 'kill!'
442-
end
443-
444-
def sock skip: false
445-
yield $stderr
446-
end
447-
448440
def respond req, res
449441
send_response(req, **res)
450442
end

0 commit comments

Comments
 (0)