Implement major math functions #336
Draft
+583
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
force-pushed
the
implement_major_math_functions
branch
from
1a93b02 to
5ebf5dc
Compare
Calculate `tan(x, prec)` by `sin(x, prec) / cos(x, denominator_prec)`. If the precision of cos is not enough, increase denominator_prec and recalculate cos again.
tompng
force-pushed
the
implement_major_math_functions
branch
from
5ebf5dc to
f29ba89
Compare
Implement BigMath version of Math.cbrt(x). Added internal-use method BigMath.int_cbrt(n): cube root version of Integer.sqrt(n)
tompng
force-pushed
the
implement_major_math_functions
branch
from
f29ba89 to
316d713
Compare
mrzasa
reviewed
Jun 20, 2025
| return BigDecimal::NAN if x.nan? | ||
| return BigDecimal::INFINITY if x.infinite? == 1 | ||
|
|
||
| prec2 = prec + BigDecimal.double_fig * 3 / 2 |
There was a problem hiding this comment.
Just curious: why do we decide what prec2 is needed? It differs between the functions and I'm wondering how it's calculated.
There was a problem hiding this comment.
Normally, BigMath functions calculate with prec+BigDecimal.double_fig precision.
I think BigMath.log2(1024, prec) is expected to return exactly 10. To calculate exact value for 2**n numbers, we need to round the result to precision = prec+BigDecimal.double_fig.
log(x)/log(2) should be calculated with prec + BigDecimal.double_fig + extra precision.
I decided to use extra=BigDeciaml.double_fig/2 here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement these methods
Remaining methods