Apply code review suggestions

Author: lsouoliveira

lib/ruby_ui/separator/separator.rb

@@ -4,38 +4,35 @@ module RubyUI
   class Separator < Base
     ORIENTATIONS = %i[horizontal vertical].freeze
 
-    def initialize(as: "div", orientation: :horizontal, decorative: true, **attrs)
+    def initialize(as: :div, orientation: :horizontal, decorative: true, **attrs)
       raise ArgumentError, "Invalid orientation: #{orientation}" unless ORIENTATIONS.include?(orientation.to_sym)
 
-      @as = as
+      @as = as.to_sym
       @orientation = orientation.to_sym
       @decorative = decorative
       super(**attrs)
     end
 
     def view_template(&)
-      public_send(@as, **attrs, &)
+      tag(@as, **attrs, &)
     end
 
     private
 
     def default_attrs
       {
-        role: (@decorative ? "none" : "separator"),
+        role: (@decorative ? 'none' : 'separator'),
         class: [
-          "shrink-0 bg-border",
+          'shrink-0 bg-border',
           orientation_classes
-        ],
-        data: {
-          orientation: @orientation
-        }
+        ]
       }
     end
 
     def orientation_classes
-      return "h-[1px] w-full" if @orientation == :horizontal
+      return 'h-[1px] w-full' if @orientation == :horizontal
 
-      "h-full w-[1px]"
+      'h-full w-[1px]'
     end
   end
 end

test/ruby_ui/separator_test.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "test_helper"
+require 'test_helper'
 
 class RubyUI::SeparatorTest < ComponentTest
   def test_render
@@ -10,15 +10,15 @@ def test_render
 
     assert_match(/div/, output)
     assert_match(/role="none"/, output)
-    assert_match(/data-orientation="horizontal"/, output)
+    assert_match(/h-\[1px\]/, output)
   end
 
   def test_render_with_vertical_orientation
     output = phlex do
       RubyUI.Separator(orientation: :vertical)
     end
 
-    assert_match(/data-orientation="vertical"/, output)
+    assert_match(/w-\[1px\]/, output)
   end
 
   def test_render_with_decorative_false
@@ -31,9 +31,9 @@ def test_render_with_decorative_false
 
   def test_render_with_custom_tag
     output = phlex do
-      RubyUI.Separator(as: "hr")
+      RubyUI.Separator(as: 'hr')
     end
 
-    assert_match(/hr/, output)
+    assert_match(/<hr/, output)
   end
 end