Implement search timeout parameter #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wiring looks good. Testing is tricky since we want to avoid performing an actual query but faking it doesn't exactly test it honestly. Will give it some thought. |
|
Going to sleep on it, but I think I want to test that the timeout integer is written out to the packet. Since it's just a timeout parameter, there's really no timeout to actually test since it's up to the server to respect the value. Longer term, I think it'd be interesting to extract out a |
Conflicts: lib/net/ldap.rb
|
👍 agree on both observations. |
added 8 commits
October 17, 2014 10:02
| def test_search_timeout | ||
| events = @service.subscribe "search.net_ldap_connection" | ||
|
|
||
| @ldap.search(:time => 5) |
There was a problem hiding this comment.
This will likely fail without a base specified.
added 2 commits
October 21, 2014 14:38
Conflicts: test/integration/test_search.rb
Closed
jch
added a commit
that referenced
this pull request
Oct 22, 2014
Implement search timeout parameter
astratto
pushed a commit
to astratto/ruby-net-ldap
that referenced
this pull request
Dec 18, 2015
Implement search timeout parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to implement timeouts for search requests (RFC 4511 4.5.1.5). I decided to name the parameter
timeto be consistent with the existingsizeparameter. I still need to figure out a good approach for testing this, but wanted to open this PR for comments.Fixes #10. Note that this is the protocol timeout, and not a hard socket timeout. That can come in a separate PR.