Skip to content

Commit db29964

Browse files
committed
Merge pull request #121 from jch/minitestify
Audit and convert tests to test/unit (minitest)
2 parents 33e452b + a686229 commit db29964

35 files changed

+679
-902
lines changed

.autotest

Lines changed: 0 additions & 11 deletions
This file was deleted.

.rspec

Lines changed: 0 additions & 2 deletions
This file was deleted.

Hacking.rdoc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ modification to +Contributors.rdoc+ to add yourself.
4040

4141
== Tests
4242

43-
The Net::LDAP team uses RSpec for unit testing; all changes must have rspec
44-
tests for any new or changed features.
43+
The Net::LDAP team uses [Minitest](http://docs.seattlerb.org/minitest/) for unit
44+
testing; all changes must have tests for any new or changed features.
4545

4646
Your changes should have been tested against at least one real LDAP server; the
4747
current tests are not sufficient to find all possible bugs. It's unlikely that
@@ -57,8 +57,6 @@ installed using RubyGems.
5757

5858
* *hoe*
5959
* *hoe-git*
60-
* *metaid*
61-
* *rspec*
6260
* *flexmock*
6361

6462
== Participation

Manifest.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
.autotest
2-
.rspec
31
.travis.yml
42
Contributors.rdoc
53
Gemfile
@@ -9,7 +7,6 @@ License.rdoc
97
Manifest.txt
108
README.rdoc
119
Rakefile
12-
autotest/discover.rb
1310
lib/net-ldap.rb
1411
lib/net/ber.rb
1512
lib/net/ber/ber_parser.rb

Rakefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ Hoe.spec 'net-ldap' do |spec|
3030

3131
spec.extra_dev_deps << [ "hoe-git", "~> 1" ]
3232
spec.extra_dev_deps << [ "hoe-gemspec", "~> 1" ]
33-
spec.extra_dev_deps << [ "metaid", "~> 1" ]
3433
spec.extra_dev_deps << [ "flexmock", ">= 1.3.0" ]
35-
spec.extra_dev_deps << [ "rspec", "~> 2.0" ]
3634

3735
spec.clean_globs << "coverage"
3836

@@ -70,7 +68,7 @@ namespace :old do
7068
end
7169
end
7270

73-
desc "Run a full set of integration and unit tests"
71+
desc "Run a full set of integration and unit tests"
7472
task :cruise => [:test, :spec]
7573

7674
# vim: syntax=ruby

autotest/discover.rb

Lines changed: 0 additions & 1 deletion
This file was deleted.

lib/net/ldap/connection.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ def initialize(server)
1515
raise Net::LDAP::LdapError, "No such address or other socket error."
1616
rescue Errno::ECONNREFUSED
1717
raise Net::LDAP::LdapError, "Server #{server[:host]} refused connection on port #{server[:port]}."
18+
rescue Errno::EHOSTUNREACH => error
19+
raise Net::LDAP::LdapError, "Host #{server[:host]} was unreachable (#{error.message})"
1820
end
1921

2022
if server[:encryption]

net-ldap.gemspec

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ the most recent LDAP RFCs (4510-4519, plutions of 4520-4532).}
2525
s.email = ["blackhedd@rubyforge.org", "gemiel@gmail.com", "rory.ocon@gmail.com", "kaspar.schiess@absurd.li", "austin@rubyforge.org"]
2626
s.extra_rdoc_files = ["Manifest.txt", "Contributors.rdoc", "Hacking.rdoc", "History.rdoc", "License.rdoc", "README.rdoc"]
2727
s.files = `git ls-files`.split $/
28+
s.test_files = s.files.grep(%r{^test})
2829
s.homepage = %q{http://github.com/ruby-ldap/ruby-net-ldap}
2930
s.rdoc_options = ["--main", "README.rdoc"]
3031
s.require_paths = ["lib"]
@@ -40,24 +41,18 @@ the most recent LDAP RFCs (4510-4519, plutions of 4520-4532).}
4041
if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
4142
s.add_development_dependency(%q<hoe-git>, ["~> 1"])
4243
s.add_development_dependency(%q<hoe-gemspec>, ["~> 1"])
43-
s.add_development_dependency(%q<metaid>, ["~> 1"])
4444
s.add_development_dependency(%q<flexmock>, [">= 1.3.0"])
45-
s.add_development_dependency(%q<rspec>, ["~> 2.0"])
4645
s.add_development_dependency(%q<hoe>, [">= 2.9.1"])
4746
else
4847
s.add_dependency(%q<hoe-git>, ["~> 1"])
4948
s.add_dependency(%q<hoe-gemspec>, ["~> 1"])
50-
s.add_dependency(%q<metaid>, ["~> 1"])
5149
s.add_dependency(%q<flexmock>, [">= 1.3.0"])
52-
s.add_dependency(%q<rspec>, ["~> 2.0"])
5350
s.add_dependency(%q<hoe>, [">= 2.9.1"])
5451
end
5552
else
5653
s.add_dependency(%q<hoe-git>, ["~> 1"])
5754
s.add_dependency(%q<hoe-gemspec>, ["~> 1"])
58-
s.add_dependency(%q<metaid>, ["~> 1"])
5955
s.add_dependency(%q<flexmock>, [">= 1.3.0"])
60-
s.add_dependency(%q<rspec>, ["~> 2.0"])
6156
s.add_dependency(%q<hoe>, [">= 2.9.1"])
6257
end
6358
end

spec/integration/ssl_ber_spec.rb

Lines changed: 0 additions & 39 deletions
This file was deleted.

spec/unit/ber/ber_spec.rb

Lines changed: 0 additions & 140 deletions
This file was deleted.

spec/unit/ber/core_ext/array_spec.rb

Lines changed: 0 additions & 24 deletions
This file was deleted.

spec/unit/ber/core_ext/string_spec.rb

Lines changed: 0 additions & 51 deletions
This file was deleted.

0 commit comments

Comments
 (0)