-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#20): Add params
option to the mustermann grape pattern for taking into account the parameter type
#21
Conversation
…rn for taking into account the parameter type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! Thanks @jcagarcia.
Let's increment the version to 1.1.0 here since this is a new feature.
@namusyaka, you around?
As you fix CI, see if it's easy to add a Ruby 3.x, feel free to make separate PRs. |
Hi @dblock , Thanks a lot for the review. I've updated the version to Let me know if something else is needed! :) |
Will let this marinate a little and see if we hear from @namusyaka, otherwise I'll merge soon. |
Hi again @dblock 👋 Do you think we can merge this change and release |
I released 1.1.0. |
@jcagarcia Want to help us with maintaining mustermann-grape? LMK your rubygems username if you're down. |
Sure @dblock ! Really happy to help :) This is my rubygems profile https://rubygems.org/profiles/jcagarcia |
Accept the maintainer invite here: https://github.com/ruby-grape/mustermann-grape/invitations. Added you to Rubygems! Thanks. |
Hey 👋
I've decided to create this PR for including the
params
options to the mustermann grape pattern. Fixing #20.I've added several tests and seems that if we provide the proper params information, we are able to generate more precise regular expressions.
What do you think?