Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Grape::Util::Accept::Header #2458

Merged
merged 3 commits into from
Jun 22, 2024
Merged

Remove Grape::Util::Accept::Header #2458

merged 3 commits into from
Jun 22, 2024

Conversation

ericproulx
Copy link
Contributor

Fix #2457

@ericproulx ericproulx marked this pull request as ready for review June 22, 2024 14:13
@ericproulx
Copy link
Contributor Author

@dblock danger is ✅ but its says that it doesn't have the write permission https://github.com/ruby-grape/grape/actions/runs/9625990185/job/26551462097?pr=2458

@ericproulx ericproulx requested a review from dblock June 22, 2024 14:21
@dblock
Copy link
Member

dblock commented Jun 22, 2024

Needs a rebase, saw a release...

@ericproulx ericproulx merged commit cc948bd into ruby-grape:master Jun 22, 2024
52 checks passed
@ericproulx ericproulx deleted the fix_2457 branch June 22, 2024 17:31
@dhruvCW
Copy link
Contributor

dhruvCW commented Jun 27, 2024

Release 2.1.1 is broken for us, could we get a new patch release with this change please ?

@dblock
Copy link
Member

dblock commented Jun 27, 2024

@ericproulx Care to release a patch version?

@ericproulx
Copy link
Contributor Author

@dhruvCW @dblock done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grape::Util::Accept::Header : empty range in char class: /^([a-z*]+)\/([a-z0-9*&\^\-
3 participants
@ericproulx @dblock @dhruvCW