Rename MissingGroupType and UnsupportedGroupType

[ericproulx]

This PR renames MissingGroupTypeError and UnsupportedGroupTypeError for consistency.

[dblock]

This is a breaking change for anyone relying on this, so would need at least a bump to 1.7. But maybe we can make it in a backward compatible way with MissingGroupTypeError = MissingGroupType?

[dblock]

I'd be happy to merge with a backwards compatible assignment of old name = new name, or a bump to 1.7.

[ericproulx]

This is a breaking change for anyone relying on this, so would need at least a bump to 1.7. But maybe we can make it in a backward compatible way with MissingGroupTypeError = MissingGroupType?

I could make an alias and we deprecate it on the next version

[dblock]

This is a breaking change for anyone relying on this, so would need at least a bump to 1.7. But maybe we can make it in a backward compatible way with MissingGroupTypeError = MissingGroupType?

I could make an alias and we deprecate it on the next version

That works for me.

[dblock]

@ericproulx Looks like CI is having trouble on master beyond rack-edge now, care to take a look?

[ericproulx]

I’ll take a look :)

…

On Mon 14 Feb 2022 at 23:34 Daniel Doubrovkine (dB.) < ***@***.***> wrote: @ericproulx <https://github.com/ericproulx> Looks like CI is having trouble on master beyond rack-edge now, care to take a look? — Reply to this email directly, view it on GitHub <#2227 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACAHJI24RI5OWGDKLUFDMRLU3F7OJANCNFSM5LFICWAA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Avertissement*
 Ce message est destiné uniquement à la personne ou à l’organisation à laquelle il est adressé et il peut contenir des informations privilégiées, confidentielles ou non divulgables en vertu de la loi. Si vous n’êtes pas le destinataire du présent message ni la personne chargée de remettre le présent message à son destinataire, il vous est strictement interdit de le divulguer, de le distribuer, de le copier ou de l’utiliser de quelque façon que ce soit. Si vous avez reçu la présente communication par erreur, veuillez en aviser l’expéditeur et détruire ou effacer tous les exemplaires que vous avez reçus.
 *Warning
 *This message is intended only for the use of the individual or entity to which it is addressed, and may contain information which is privileged, confidential, proprietary or exempt from disclosure under applicable law. If you are not the intended recipient or the person responsible for delivering the message to the intended recipient, you are strictly prohibited from disclosing, distributing, copying or in any way using this message. If you have received this communication in error, please notify the sender, and destroy and delete any copies you may have received.

[ericproulx]

While testing locally, I found that Rack::Multipart::UploadedFile and File special types,

grape/lib/grape/validations/types/file.rb

Lines 1 to 15 in e93d278

	# frozen_string_literal: true
	module Grape
	module Validations
	module Types
	# Implementation for parameters that are multipart file objects.
	# Actual handling of these objects is provided by +Rack::Request+;
	# this class is here only to assert that rack's handling has succeeded.
	class File
	class << self
	def parse(input)
	return if input.nil?
	return InvalidValue.new unless parsed?(input)
	# Processing of multipart file objects

input.nil? is false on rack-edge but true on a rack 2.2.3

A quick fix would be to check input.blank? but I'm not sure it's what we want

[dblock]

A quick fix would be to check input.blank? but I'm not sure it's what we want

So input is an empty string? Weird.