Fix validation error for nested array when requires => optional => requires
#2128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwhenry
force-pushed
the
fix-nested-validations
branch
from
1714f21 to
33a57a9
Compare
…> `requires`
This bug is due to the params parsing code return `{}` when the value is not found.
This is fine in most cases, however in the instance that the value was optional
and has nested required values.
I was not able to find a way to confind the changes to just the parameter parsing
as this resulted in the indexing being incorrect if any of the other array objects
had an error.
I have used a class to indicate that an Optional Value was missing as this avoid issues
with the value actually being in the response.
Member
|
Looks like there are some legit spec failures here ... cc: @stanhu @dm1try @dnesteryuk who dealt with params recently to add some comments |
dblock
reviewed
Nov 5, 2020
| # are the parameter parsing stage as they are required to ensure | ||
| # the correct indexing is maintained | ||
| def skip?(val) | ||
| # return false |
Member
|
Try writing more specs with other combinations of required parameters inside optional ones? I suspect we have similar problems with hash parameters and combinations of arrays and hashes. |
…onents This adds a number of tests around edge cases and different structures that could result in the previous validation incorrectly reporting missing data as a result of an optional element not being present.
dwhenry
force-pushed
the
fix-nested-validations
branch
from
741ed9b to
2647e2c
Compare
Contributor
Author
|
@dblock added tests for all the edge cases that I believe this would affect and they all pass with this change. Let me know if you can think of anything else it would be worth testing. |
Member
|
i'm merging this |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is due to the params parsing code return
{}when the value is not found.This is fine in most cases, however in the instance that the value was optional
and has nested required values.
I was not able to find a way to confine the changes to just the parameter parsing
as this resulted in the indexing being incorrect if any of the other array objects
had an error.
I have used a class to indicate that an Optional Value was missing as this avoid issues
with the value actually being in the response.