Simplify logic for defining declared params

[dnesteryuk]

Now, route settings get declared params when an endpoint gets initialized, the Grape::Validations::ParamsScope doesn't need to worry about that anymore.

Since the endpoint takes care of finalizing declared params, the declared_params method works with a structure which doesn't require any processing.

[dblock]

👍

[dblock]

This caused ruby-grape/grape-swagger#801, at the very least this is not expected.

Got some time to look at it, @dnesteryuk? I don't understand what changed or why grape-swagger was doing all this work here. Looks like the internal setting :declared_params is no longer behaving as before, but the grape-swagger code shouldn't be relying on that anyway.

[dnesteryuk]

@dblock yeah, I will take a look this week

[LeFnord]

@dnesteryuk … think it's not realy needed, cause declared_params will not be used anymore in grape-swagger

[dnesteryuk]

@LeFnord thanks for you fix 👍

[mobilutz]

In a project I am working on, we used the @declared_params attribute to get data for a StrictHash Validator.

Is there an alternative way now to get declared_params within a Validator?

This is the validator pseudo code:

        def validate_param!(attr_name, params)
          actual_keys = params[attr_name].keys.map(&:to_sym)
          errors = (actual_keys - allowed_keys).map { |key| error(key, attr_name) }
          
          raise ::Grape::Exceptions::ValidationArrayErrors, errors if errors.any?
        end

        def allowed_keys
          # NOTE: This of course does not return the real keys, just shows that we used the now `nil` @declared_params
          @allowed_keys ||= @scope.instance_variable_get(:@declared_params)
        end