Modify declared for nested array and hash #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadotami
changed the title
kadotami
force-pushed
the
fix_declared_for_nested_array_and_hash
branch
3 times, most recently
from
c55af12
to
8cbec94
Compare
dnesteryuk
reviewed
Apr 27, 2020
| @@ -422,6 +425,7 @@ def app | |||
| get '/declared?first=present' | |||
| expect(last_response.status).to eq(200) | |||
| expect(JSON.parse(last_response.body)['nested']).to be_a(Hash) | |||
| expect(JSON.parse(last_response.body)['nested']).to eq({}) | |||
There was a problem hiding this comment.
what do you think about parsing the response only once?
There was a problem hiding this comment.
sorry! I'll modify soon.
kadotami
force-pushed
the
fix_declared_for_nested_array_and_hash
branch
from
8cbec94
to
00162f5
Compare
kadotami
force-pushed
the
fix_declared_for_nested_array_and_hash
branch
from
00162f5
to
3551c67
Compare
|
👍 |
This was referenced May 14, 2020
This was referenced Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed bugs of declared method.
key of options[:route_options][:params] is not considered for nested params.
I changed to these.