Make helpers available in subclasses #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating settings code to define :top_level_setting with parent's :inheritable_setting when available. This will emulate inheritance, with its expected capabilities (sharing and overriding).
dblock
approved these changes
Jul 24, 2017
lib/grape/dsl/settings.rb
Outdated
|
|
||
| # Obtains the current class :inheritable_setting. If available, it returns the superclass's :inheritable_setting. | ||
| # Otherwise, a clean :inheritable_setting is returned. | ||
| def obtain_top_level_setting |
There was a problem hiding this comment.
I don't love the obtain name, maybe just get, another more common variation is build?
There was a problem hiding this comment.
Agreed! Updated in 1a3ba3f
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating settings code to define
:top_level_settingwith parent's:inheritable_settingwhen available. This will emulate inheritance,with its expected capabilities (sharing and overriding).
This fixes #1617