-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplicated calls in StackableValue#[] #1561
Avoid duplicated calls in StackableValue#[] #1561
Conversation
3 similar comments
Travis-CI builds are failing on Ruby 2.3.3 and Ruby 2.4, due to this issue in Rainbow 2.2.1 : ku1ik/rainbow#48 |
Please also refer to: travis-ci/travis-ci#7204 |
Fixed in PR #1562 . |
This makes a lot of sense. Rebase (I merged #1562) please, and add a CHANGELOG line in line with something like "Improved performance of ..." so that it becomes a visible change. |
061cf11
to
882eb65
Compare
Generated by 🚫 danger |
2 similar comments
Thanks @brucehsu. I'll make a minor release sometime soon. |
Fixing the performance issue mentioned in issue #1560 by eliminating duplicated calls of
StackableValue#[]
in one-liner conditionals.