Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Grape helpers modified given helper module #1338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Grape helpers modified given helper module #1338

wants to merge 1 commit into from

Conversation

sevaorlov
Copy link

fixes #1335

@sevaorlov sevaorlov force-pushed the fix/grape-helper-module branch 4 times, most recently from 8737400 to 98e6516 Compare March 26, 2016 11:55
@dblock
Copy link
Member

dblock commented Apr 1, 2016

I am torn whether we want this. If you think "this is a Ruby module", then in Ruby if you write module MyHelperModule you'd expect it to reopen a previous one. On the other hand, we could consider modules namespaces, and maybe what you suggest has less of a surprise. Please add your 👍 or 👎 to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grape::DSL::Helpers::ClassMethods#helpers modifies helper module
2 participants
@sevaorlov @dblock