Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should custom formatters have access to headers and status? #902

Open
adamgotterer opened this issue Jan 17, 2015 · 1 comment
Open

Should custom formatters have access to headers and status? #902

adamgotterer opened this issue Jan 17, 2015 · 1 comment

Comments

@adamgotterer
Copy link
Contributor

I've been working on some custom formatters and realized that there is no control over the headers and status within the formatter or error formatter. The change is relatively easy to make but it will break backwards compatibility because the custom formatters will need to take new additional parameters. The other option would be to exec custom formatters against the grape formatter middleware and expose functions in a DSL like format.

Thoughts?

@dblock
Copy link
Member

dblock commented Jan 18, 2015

I vote to go the DSL route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants