Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider defaulting version to :using => :path #85

Closed
dblock opened this issue Nov 28, 2011 · 3 comments
Closed

Consider defaulting version to :using => :path #85

dblock opened this issue Nov 28, 2011 · 3 comments

Comments

@dblock
Copy link
Member

dblock commented Nov 28, 2011

The previous release behaved with

`version 'v1', :using => :path`

Anyone upgrading Grape is going to have to add :using => :path in their versions, maybe worth defaulting to this.

@amrnt
Copy link

amrnt commented Dec 8, 2011

I think its here now: 0529e92#L1R80

@dblock
Copy link
Member Author

dblock commented Dec 10, 2011

Not on Frontier. It will be a clearly breaking change, https://github.com/intridea/grape/blob/frontier/lib/grape/api.rb.

@mbleigh mbleigh closed this as completed Dec 14, 2011
@mbleigh
Copy link
Contributor

mbleigh commented Dec 14, 2011

I'm leaving things as-is on frontier because I want this to be the default going forward and so the next major release will be this way. I reverted the default on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants