Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for msgpack #668

Open
alec-c4 opened this issue Jun 30, 2014 · 4 comments
Open

support for msgpack #668

alec-c4 opened this issue Jun 30, 2014 · 4 comments

Comments

@alec-c4
Copy link

alec-c4 commented Jun 30, 2014

Hi, guys.
Could you please add support for msgpack (http://msgpack.org) in grape? I've found https://github.com/rosylilly/grape-msgpack, but i think it will be better to have msgpack support as part of grape.

@mbleigh
Copy link
Contributor

mbleigh commented Jun 30, 2014

@dblock your call, but my vote would be 👎

In general there are already things in Grape that I'd prefer we break out into separate gems, so I'm definitely not interested in adding more dependencies to the core lib.

@dblock
Copy link
Member

dblock commented Jun 30, 2014

I agree with @mbleigh, we want Grape to be more modular vs. less modular as it grows. I'd love a PR that talks about msgpack support in README though, please?

@purezen
Copy link

purezen commented Feb 19, 2015

You mean, a link to the grape-msgpack repo? @dblock

@dblock
Copy link
Member

dblock commented Feb 20, 2015

See, I didn't know about https://github.com/rosylilly/grape-msgpack :) So yes, feel free to call that out the same way we talk about ActiveModelSerilizers for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants