Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoerceValidator broken by major release of virtus-1.0.0 #488

Closed
JimGaylard opened this issue Oct 17, 2013 · 2 comments
Closed

CoerceValidator broken by major release of virtus-1.0.0 #488

JimGaylard opened this issue Oct 17, 2013 · 2 comments

Comments

@JimGaylard
Copy link

I was having trouble with a Grape app after a bundle update. Turns out virtus updated from 0.5.5 to 1.0.0 very recently and the Changelog lists a breaking change.

I checked out Grape and ran the test suite and it's failing on the CoerceValidator.
https://gist.github.com/JimGaylard/7022850

I haven't had time to work out a fix but wanted to report it. I've explicitly locked virtus at 0.5.5 in my Gemfile and the tests are all passing so I'm pretty confident that's what is causing it.

@dblock
Copy link
Member

dblock commented Oct 17, 2013

We should upgrade virtus in Grape dependencies and make whatever fixes are needed.

@dblock
Copy link
Member

dblock commented Oct 17, 2013

Fixed in 67d3f79.

@dblock dblock closed this as completed Oct 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants