Log formats silently changed between versions

[rhunter]

The default Logger format seems to have changed between Grape v0.2.6 and v0.3.1 -- such that our logs stopped recording timestamp and log level information.

I'm not sure if the older version had the "right" behaviour and it's now broken, or whether we relied on an inappropriate default and were just lucky.

$ git checkout v0.3.1
$ ruby -r bundler/setup -I lib -r grape -r grape/api -e "Logger.new(STDOUT).info 'hi'"
hi
$ git checkout v0.2.6
$ ruby -r bundler/setup -I lib -r grape -r grape/api -e "Logger.new(STDOUT).info 'hi'"
I, [2013-02-27T18:39:20.352350 #85986]  INFO -- : hi

Using the wonderful git bisect, I narrowed it down to commit 11576c8 -- XML support for entitiies -- but I can't figure out what the relevant change is.

ActiveSupport? i18n? Something else?

[rhunter]

It turns out the ActiveSupport logger extensions (require 'active_support/core_ext/logger) change the default log format -- and after commit 11576c8, Grape required all of ActiveSupport including the logger extensions.

I see two solutions:

• Grape goes back to using just the ActiveSupport parts it needs. I've sent a pull request with the necessary changes.
• Grape 0.3+ decides to use all of ActiveSupport. Thus, any app that wants the standard Ruby log format must provide a logger that does so (my_logger.format = Logger::Format.new)

I guess it boils down to whether Grape "has an opinion" on logging.

What do you think?

[dblock]

If Grape doesn't need all of ActiveSupport, it shouldn't require it. I'll take your PR.

[dblock]

See #354, fixed.