Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Appraisals by eval_gemfile ? #2428

Closed
ericproulx opened this issue Apr 9, 2024 · 3 comments
Closed

Replace Appraisals by eval_gemfile ? #2428

ericproulx opened this issue Apr 9, 2024 · 3 comments
Labels

Comments

@ericproulx
Copy link
Contributor

ericproulx commented Apr 9, 2024

Most gemfiles are sharing the same structure/gems and when it's time to update dependencies, we have to update all the them. Recently, I came across Bundler's DSL where you can call eval_gemfile in it.

For instance gemfiles/rack_3_0.gemfile could by simplify as

# frozen_string_literal: true

eval_gemfile '../Gemfile'

gem 'rack', '~> 3.0.0'

That way all specific Gemfiles could rely on the base Gemfile to fill the common structure and we could drop Appraisals

@dblock
Copy link
Member

dblock commented Apr 10, 2024

Interesting. Appraisals are generated by a tool from spec, so does this really help or make it more confusing when adding new ones?

@dblock dblock added the chore label Apr 10, 2024
@ericproulx
Copy link
Contributor Author

Personnally, when creating a new Gemfile, I just copy/past from an existing one and changing the gem manually. Configuring Appraisals feels cumbersome.

@ericproulx
Copy link
Contributor Author

Done #2431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants