Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails reloading instructions no longer required? #1766

Open
yeonhoyoon opened this issue Jun 14, 2018 · 3 comments
Open

Rails reloading instructions no longer required? #1766

yeonhoyoon opened this issue Jun 14, 2018 · 3 comments
Labels

Comments

@yeonhoyoon
Copy link

Gem versions
Rails: 5.2.0
Grape: 1.0.3

In a blank state rails app created by rails new, API changes in grape seems to be picked up by rails without any modification in application.rb or creating initializer files to listen on callbacks.

I've put the files in correct directory, as per usual in rails, but nothing more.
Adding new apis and modifying existing apis is hot-reloaded without restarting the app.
Is there anything else I need to check to confirm this?

If these instructions are indeed no longer required, I'll create a PR to modify the grape README file.

@dblock
Copy link
Member

dblock commented Jun 14, 2018

If that works, I say PR it. Thanks!

@dblock dblock added the chore label Jun 14, 2018
@jeffclemens
Copy link

FWIW, the only configuration I found to be necessary in Rails 5.1.2 is to mount in config/routes.rb. The autoloader-related change to application.rb was not required.

@brianweiner
Copy link

FWIW I still experience:
ArgumentError (A copy of API::V1::Defaults has been removed from the module tree but is still active!)
when I make changes to a definition file without restarting the dev server.

Rails 5.1.7
grape 1.0.3

I mount in config/routes.rb like so mount API::Base, at: '/'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants