Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grape 1.0.0 #1598

Closed
namusyaka opened this issue Mar 21, 2017 · 11 comments
Closed

Grape 1.0.0 #1598

namusyaka opened this issue Mar 21, 2017 · 11 comments

Comments

@namusyaka
Copy link
Contributor

@dblock I'd like to start moving toward 1.0.0.

@dblock
Copy link
Member

dblock commented Mar 21, 2017

As much as I enjoy 0.x, I'm with you!

@dblock
Copy link
Member

dblock commented Mar 21, 2017

Things like #1594 could definitely justify a major version bump.

@dblock dblock added the chore label Mar 21, 2017
@namusyaka
Copy link
Contributor Author

Yes, the Hashie replacement is big feature. I think that it could justify the major version, too.
However, 1.0.0 must be released as our first stable version. Therefore, I would like to release the version several times (e.g. rc1, rc2).

@dblock
Copy link
Member

dblock commented Mar 21, 2017

I like your suggestion @namusyaka, go for it.

@namusyaka namusyaka added this to the 1.0.0 milestone Apr 11, 2017
@namusyaka
Copy link
Contributor Author

namusyaka commented Apr 11, 2017

I have just created the 1.0.0 milestone.

@dblock
Copy link
Member

dblock commented Apr 25, 2017

How do we feel about actually cutting a 1.0?

@namusyaka
Copy link
Contributor Author

@dblock I'd like to merge other pull requests waiting for review if possible.
I'm going to confirm the PRs in a few days.

@namusyaka
Copy link
Contributor Author

I really sorry, I'm unlikely to be able to work for a while because I have lost my physical condition.
I would like to entrust you release v1.0.0.

@dblock
Copy link
Member

dblock commented May 3, 2017

Feel better @namusyaka!

@dblock dblock closed this as completed in 9f81fb6 Jul 3, 2017
@dblock
Copy link
Member

dblock commented Jul 3, 2017

I've released 1.0.

@namusyaka
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants