Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mustermann dependency ? #1511

Closed
jarthod opened this issue Oct 16, 2016 · 14 comments
Closed

Upgrade mustermann dependency ? #1511

jarthod opened this issue Oct 16, 2016 · 14 comments
Assignees
Labels

Comments

@jarthod
Copy link

jarthod commented Oct 16, 2016

I'm currently having trouble updating an app to Rails 5 because of this dependency, here's why:

  • rails 5 depends on rack 2
  • rack 2 requires sinatra 2+
  • sinatra 2 requires mustermann 1
  • grape 0.18 depends on mustermann-grape 0.4 which depends on mustermann 0.4

So this is a deadlock and I can't bundle this. I tried to find mustermann-grape to see if we could upgrade the dependency but I can't find it, It seems with a github search that the Grape extension is now in mustermann-contrib.

So I guess grape is now supposed to depend on mustermann-contrib ?

@namusyaka
Copy link
Contributor

@jarthod Thanks for yourt report! I'm going to investigate the problem in a few days.

@namusyaka namusyaka self-assigned this Oct 17, 2016
@dblock
Copy link
Member

dblock commented Oct 17, 2016

I heard from @zzak that the conttrib stuff was a result of merging many gems? Maybe he can help shed some light on what's going on?

@dblock dblock added the bug? label Oct 17, 2016
@namusyaka
Copy link
Contributor

Well, I found a few points.

  • rack-2.0 seems not to depend on sinatra
  • sinatra-2.0 depends on mustermann-1, but they're still in beta.

And then, I think we have two approach for managing mustermann gem.

  • Continue to maintain mustermann-grape.
  • Use mustermann-contrib instead of mustermann-grape.

If we decide to use mustermann-contrib, it does not affect to our development, I think.

@dblock
Copy link
Member

dblock commented Oct 21, 2016

I think we should use whatever is maintained.

@namusyaka
Copy link
Contributor

Yes, both mustermann-contrib and mustermann-grape can be maintained.
Btw I think mustermann-grape is hosted by me, so we can feel free to cut a release of the gem.

@dblock
Copy link
Member

dblock commented Oct 23, 2016

Sounds good. Maybe you want to move it into the Grape organization @namusyaka?

@namusyaka
Copy link
Contributor

Exactly. Mustermann will be continued to be used by us.
In other words, the gem is considered to be the most desirable that we can handle.

@dblock
Copy link
Member

dblock commented Nov 3, 2016

If you don't have org permissions move it to me and I'll move it to the org @namusyaka.

@namusyaka
Copy link
Contributor

@zzak
Copy link

zzak commented Nov 16, 2016

Sounds good to me, let me know if you need anything from me.

Thanks

@shaneog
Copy link

shaneog commented Nov 23, 2016

Also stuck due to the same upgrade. Would be great to use the new gem and release. Is there anything I can do to help?

@namusyaka
Copy link
Contributor

Sorry fory the late reply. I've just released v1.0.0.beta2.

I'm going to close this issue, but if you still have the problem, please let me know.
Thanks!

@russellsilva
Copy link

russellsilva commented Feb 9, 2017

Thanks @namusyaka for the mustermann-grape update. Does that update alone fix this issue though? Grape itself still depends on mustermann-grape 0.4.0. Does that need to be changed to resolve the original dependency deadlock described by @jarthod?

@namusyaka
Copy link
Contributor

@russellsilva I'm going to cut new release mustermann-grape-1.0.0 after releasing official mustermann-1.0.0, and then we will release new grape.

To avoid dependency dead lock, you can use this branch by adding following line to your Gemfile.

gem 'grape', branch: 'upgrade-mustermann', github: 'ruby-grape/grape'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants