Skip to content

Added the token api_auth type #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Conversation

Jack12816
Copy link
Contributor

Hey guys, first things first: thanks for this great gem!

It would be quite useful to have a new token authentication type,
which follows the Rails convention. So the Authorization header
looks like this:

Authorization: Token token="WCZZYjnOQFUYfJIN2ShH1iD24UHo58A6TI"

This PR allows the usage of this authentication.

@grape-bot
Copy link

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 danger

@dblock
Copy link
Member

dblock commented Oct 26, 2018

Something's wrong with the build. Care to fix that? Probably needs some capybara updates and what not. I can merge on green.

Generally this auth business implementation is weird. Swagger ui has a much more sophisticated way to do this in 3.0, someone will have to redo it I think when we get there. There's also a more generic way to handle this via preFetch (eg. artsy/doppler#139).

@olleolleolle
Copy link
Contributor

master should build now, so this PR could be re-based to re-run it.

@dblock
Copy link
Member

dblock commented Feb 3, 2019

@Jack12816 Rebase/squash? I'll merge.

Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
@Jack12816
Copy link
Contributor Author

Sorry guys I didn't have time to look into the broken build. But I rebased against the latest upstream master right now. Feel free to merge :)

@dblock dblock merged commit a764d6d into ruby-grape:master Feb 4, 2019
@Jack12816
Copy link
Contributor Author

@dblock Is there a release planned for this?

@dblock dblock mentioned this pull request Feb 14, 2019
@dblock
Copy link
Member

dblock commented Feb 14, 2019

I opened #93 for the maintainers of this repo. I am just cheerleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants