Merge pull request #53 from sue445/module_function

Add rb_define_module_function

Author: sue445

README.md

@@ -126,7 +126,7 @@ ref. https://docs.ruby-lang.org/ja/latest/function/index.html
 * [x] `rb_define_method`
 * [ ] `rb_define_method_id`
 * [x] `rb_define_module`
-* [ ] `rb_define_module_function`
+* [x] `rb_define_module_function`
 * [ ] `rb_define_module_id`
 * [x] `rb_define_module_under`
 * [ ] `rb_define_private_method`

ruby-internal-method.go

@@ -19,3 +19,15 @@ func RbDefineMethod(klass VALUE, mid string, fun unsafe.Pointer, arity int) {
 
 	C.rb_define_method(C.VALUE(klass), midChar, toFunctionPointer(fun), C.int(arity))
 }
+
+// RbDefineModuleFunction calls `rb_define_module_function` in C
+//
+// Original definition is following
+//
+//	void rb_define_module_function(VALUE klass, const char *mid, VALUE (*func)(ANYARGS), int arity)
+func RbDefineModuleFunction(klass VALUE, mid string, fun unsafe.Pointer, arity int) {
+	midChar, midCharClean := string2Char(mid)
+	defer midCharClean()
+
+	C.rb_define_module_function(C.VALUE(klass), midChar, toFunctionPointer(fun), C.int(arity))
+}

testdata/dummy/ext/dummy/dummy.go

@@ -8,6 +8,7 @@ VALUE rb_dummy_with_block(VALUE self, VALUE arg);
 VALUE rb_dummy_hello(VALUE self, VALUE name);
 VALUE rb_dummy_round_num(VALUE self, VALUE num, VALUE ndigits);
 VALUE rb_dummy_to_string(VALUE self, VALUE source);
+VALUE rb_dummy_max(VALUE self, VALUE a, VALUE b);
 
 VALUE rb_dummy_unit_kilobyte(VALUE self);
 */
@@ -71,6 +72,18 @@ func rb_dummy_unit_kilobyte(self C.VALUE) C.VALUE {
 	return C.VALUE(ruby.INT2NUM(result))
 }
 
+//export rb_dummy_max
+func rb_dummy_max(_ C.VALUE, a C.VALUE, b C.VALUE) C.VALUE {
+	aLong := ruby.NUM2LONG(ruby.VALUE(a))
+	bLong := ruby.NUM2LONG(ruby.VALUE(b))
+
+	if aLong > bLong {
+		return C.VALUE(ruby.LONG2NUM(aLong))
+	}
+
+	return C.VALUE(ruby.LONG2NUM(bLong))
+}
+
 var rb_mDummy ruby.VALUE
 
 //export Init_dummy
@@ -81,6 +94,7 @@ func Init_dummy() {
 	ruby.RbDefineSingletonMethod(rb_mDummy, "hello", C.rb_dummy_hello, 1)
 	ruby.RbDefineSingletonMethod(rb_mDummy, "round_num", C.rb_dummy_round_num, 2)
 	ruby.RbDefineSingletonMethod(rb_mDummy, "to_string", C.rb_dummy_to_string, 1)
+	ruby.RbDefineModuleFunction(rb_mDummy, "max", C.rb_dummy_max, 2)
 
 	// Create Dummy::InnerClass class
 	ruby.RbDefineClassUnder(rb_mDummy, "InnerClass", ruby.VALUE(C.rb_cObject))

testdata/dummy/sig/dummy.rbs

@@ -14,6 +14,9 @@ module Dummy
 
   def self.to_string: (untyped source) -> String
 
+  def self.max: (Integer, Integer) -> Integer
+  def max: (Integer, Integer) -> Integer
+
   class InnerClass
   end
 

testdata/dummy/spec/dummy_spec.rb

@@ -47,4 +47,38 @@
       expect(actual).to eq "123"
     end
   end
+
+  describe ".max" do
+    context "a > b" do
+      it "works" do
+        actual = Dummy.max(3, 2)
+        expect(actual).to eq 3
+      end
+    end
+
+    context "a < b" do
+      it "works" do
+        actual = Dummy.max(1, 2)
+        expect(actual).to eq 2
+      end
+    end
+  end
+
+  describe "#max" do
+    include Dummy
+
+    context "a > b" do
+      it "works" do
+        actual = max(3, 2)
+        expect(actual).to eq 3
+      end
+    end
+
+    context "a < b" do
+      it "works" do
+        actual = max(1, 2)
+        expect(actual).to eq 2
+      end
+    end
+  end
 end