Skip to content

Commit

Permalink
Add a windows job to CI
Browse files Browse the repository at this point in the history
  • Loading branch information
Earlopain authored and eregon committed Jun 7, 2024
1 parent 393ad72 commit c672d6e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,24 @@ concurrency:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}-latest
timeout-minutes: 10

strategy:
fail-fast: false
matrix:
ruby: [2.3, 2.4, 2.5, 2.6, 2.7, '3.0', 3.1, 3.2, 3.3, jruby, truffleruby]
os: [ubuntu]
include:
- ruby: 3.3
os: windows

env:
JAVA_OPTS: '-Xmx1024m'
RUBYOPT: '-w'
JRUBY_OPTS: '--dev'

name: "Tests: Ruby ${{ matrix.ruby }}"
name: "Tests: Ruby ${{ matrix.ruby }} - ${{ matrix.os }}"
steps:
- name: Clone Repo
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion spec/concurrent/channel/integration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
end

specify 'default-selection.rb' do
skip('flaky') if Concurrent.on_jruby? || Concurrent.on_truffleruby?
skip('flaky') if Concurrent.on_jruby? || Concurrent.on_truffleruby? || Concurrent.on_windows?
expected = <<-STDOUT
.
.
Expand Down
1 change: 1 addition & 0 deletions spec/concurrent/promises_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,7 @@ def behaves_as_delay(delay, value)
describe 'value!' do
%w[with without].each do |timeout|
it "does not return spuriously #{timeout} timeout" do
skip "SIGHUP not supported" if Concurrent.on_windows?
# https://github.com/ruby-concurrency/concurrent-ruby/issues/1015
trapped = false
original_handler = Signal.trap(:SIGHUP) { trapped = true }
Expand Down

0 comments on commit c672d6e

Please sign in to comment.