Skip to content

Commit 9ffdff7

Browse files
committed
Merge pull request #365 from ruby-concurrency/fixed-build-bugs
Fixed bugs found while building the 0.9 release.
2 parents e77e51f + 9a1b42b commit 9ffdff7

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

CHANGELOG.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
### Next Release v0.9.0 (Target Date: 7 June 2015)
2-
1+
## Current Release v0.9.0 (10 July 2015)
32

43
* Updated `AtomicReference`
54
- `AtomicReference#try_update` now simply returns instead of raising exception
@@ -98,7 +97,7 @@
9897
* Removed brute-force killing of threads in tests
9998
* Fixed a thread pool bug when the operating system cannot allocate more threads
10099

101-
## Current Release v0.8.0 (25 January 2015)
100+
### Release v0.8.0 (25 January 2015)
102101

103102
* C extension for MRI have been extracted into the `concurrent-ruby-ext` companion gem.
104103
Please see the README for more detail.

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ gemspec name: 'concurrent-ruby-edge'
66
group :development do
77
gem 'rake', '~> 10.4.2'
88
gem 'rake-compiler', '~> 0.9.5'
9-
gem 'rake-compiler-dock', '~> 0.4.2'
9+
gem 'rake-compiler-dock', '~> 0.4.3'
1010
gem 'gem-compiler', '~> 0.3.0'
1111
gem 'benchmark-ips', '~> 2.2.0'
1212

Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ $:.push File.join(File.dirname(__FILE__), 'lib')
55
require 'concurrent/version'
66
require 'concurrent/utility/native_extension_loader'
77

8-
## load the two gemspec files
8+
## load the gemspec files
99
CORE_GEMSPEC = Gem::Specification.load('concurrent-ruby.gemspec')
1010
EXT_GEMSPEC = Gem::Specification.load('concurrent-ruby-ext.gemspec')
1111
EDGE_GEMSPEC = Gem::Specification.load('concurrent-ruby-edge.gemspec')

lib/concurrent/concern/logging.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
require 'logger'
2-
require 'concurrent/configuration'
32

43
module Concurrent
54
module Concern
@@ -16,6 +15,8 @@ module Logging
1615
# @param [String, nil] message when nil block is used to generate the message
1716
# @yieldreturn [String] a message
1817
def log(level, progname, message = nil, &block)
18+
#NOTE: Cannot require 'concurrent/configuration' above due to circular references.
19+
# Assume that the gem has been initialized if we've gotten this far.
1920
(@logger || Concurrent.global_logger).call level, progname, message, &block
2021
rescue => error
2122
$stderr.puts "`Concurrent.configuration.logger` failed to log #{[level, progname, message, block]}\n" +

lib/concurrent/utility/at_exit.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
require 'concurrent/concern/logging'
1+
require 'logger'
22
require 'concurrent/synchronization'
33

44
module Concurrent
@@ -8,7 +8,7 @@ module Concurrent
88
#
99
# @!visibility private
1010
class AtExitImplementation < Synchronization::Object
11-
include Concern::Logging
11+
include Logger::Severity
1212

1313
def initialize(*args)
1414
super()
@@ -46,9 +46,9 @@ def handlers
4646
def install
4747
synchronize do
4848
@installed ||= begin
49-
at_exit { runner }
50-
true
51-
end
49+
at_exit { runner }
50+
true
51+
end
5252
self
5353
end
5454
end
@@ -71,7 +71,7 @@ def run
7171
begin
7272
handler.call
7373
rescue => error
74-
log ERROR, error
74+
Concurrent.global_logger.call(ERROR, error)
7575
end
7676
end
7777
handlers.keys

0 commit comments

Comments
 (0)