Add ActionCable benchmarks for PostgreSQL and Redis #54
Conversation
| Benchmark.rails("actioncable_postgres", time: 10) do | ||
| pg_config = { adapter: 'postgresql', url: PG_DB_URL }.with_indifferent_access | ||
| with_puma_server(ActionCable.server, 4001, pg_config) do |port| | ||
| sleep |
There was a problem hiding this comment.
This server needs to run in the background. Not sure how that will be handled, given that the actual benchmark itself needs to be run.
|
@maclover7 I didn't forget about this :P Was busy last week. I'll get merge in by this week |
|
👍 |
|
ping @tgxworld |
|
In beta2 actioncable runs in ssme process |
| @@ -25,3 +25,5 @@ gem 'sqlite3', '1.3.10' | |||
| gem 'mysql2', '0.3.18' | |||
| gem 'pg', '0.18.1' | |||
| gem 'benchmark-ips', '~> 2.2.0' | |||
| gem 'em-hiredis', '~> 0.3.0' | |||
| gem 'redis', '~> 3.0' | |||
There was a problem hiding this comment.
I think we might need to add faye-websocket in here too
|
Hi @maclover7 Sorry for dropping the ball on this 😢 . Anyway I couldn't get the benchmark to run. Here is what I tried: I got this |
|
^ The above commit works for me. |
|
Hmmm ok let me look into it then.. |
|
Sorry -- wasn't clear there. Pushed up a commit number 2 that fixes the error you were seeing. I was seeing it as well before my fix 😄 |
| @@ -25,3 +25,7 @@ gem 'sqlite3', '1.3.10' | |||
| gem 'mysql2', '0.3.18' | |||
| gem 'pg', '0.18.1' | |||
| gem 'benchmark-ips', '~> 2.2.0' | |||
| gem 'em-hiredis', '~> 0.3.0' | |||
| gem 'redis', '~> 3.0' | |||
| gem 'faye-websocket' | |||
There was a problem hiding this comment.
I usually lock the versions so that we know any performance changes are not due to the gems
|
Thanks @maclover7!!!! |
Add ActionCable benchmarks for PostgreSQL and Redis
First kick at this. Let me know if any improvements need to be made!
cc @tgxworld @SamSaffron