Replace azapi_resource workaround with azurerm_storage_container_immutability_policy

[DamaniN]

Is your feature request related to a problem? Please describe.

Microsoft and Terraform have released a azurerm_storage_container_immutability_policy resource. This workaround can now be replaced by that:

# Workaround until azurerm_storage_container supports setting the version level immutability option.
# See https://github.com/hashicorp/terraform-provider-azurerm/issues/21512 
# and https://github.com/hashicorp/terraform-provider-azurerm/issues/3722 for more details.

resource "azapi_resource" "cc_container" {

  type = "Microsoft.Storage/storageAccounts/blobServices/containers@2022-09-01"
  name      = var.cluster_name

  # We append '/blobServices/default' to the storage_account.id see desc. above
  parent_id = "${azurerm_storage_account.cc_storage_account.id}/blobServices/default"

  body = jsonencode({
    properties = {
      immutableStorageWithVersioning = {
        enabled = "${var.enableImmutability}"
      }
      publicAccess = "None"
    }
  })
}

Describe the solution you'd like

Replace azapi_resource workaround with:

resource "azurerm_storage_container_immutability_policy" "example" {
  storage_container_resource_manager_id = azurerm_storage_container.example.resource_manager_id
  immutability_period_in_days           = 14
  protected_append_writes_all_enabled   = false
  protected_append_writes_enabled       = true
}

Describe alternatives you've considered

None

Additional context

None

[DamaniN]

Looking at this new resource, it requires setting the immutability_period_in_days. That may cause a conflict with CCES and needs to be tested. In theory, if the immutability_period_in_days is set to a low value (like 3 days) CCES can extend the lock afterward.

It also requires version 4.2.0 of the Azure provider. The minimum AzureRM provider version will need to be updated as well.

[DamaniN]

This feature also requires that a immutability_policy block be added to the azurerm_storege_account block.