Add guideline for using safe operator. #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
reviewed
Dec 25, 2022
| @@ -323,6 +323,29 @@ foo&. bar | |||
| foo&.bar | |||
| ---- | |||
|
|
|||
| === Safe navigation | |||
There was a problem hiding this comment.
I'd argue regarding the section, Source code layout.
Maybe it would be a better fit for Misc?
There was a problem hiding this comment.
Can you elaborate more regarding this comment?
There was a problem hiding this comment.
If I'm not mistaken, presently this new guideline resides in the "Source code layout" section. This section is mostly all about whitespace, formatting, those things that don't change code semantics.
The new guideline suggests code changes that may, depending on constraints, change its behaviour.
Basing on this observation, I propose moving this new guideline to a different section. I don't have a better section in mind, so I suggested "Misc".
pirj
reviewed
Dec 26, 2022
add language name along with source.
andyw8
approved these changes
Dec 29, 2022
|
Thank you, @Gauravpurohit409 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#889 - Add guidance for safe navigation operator (&.)
Based on the 889 issue added guidelines for using safe navigation operators using some resources from the thought bot.
The idea here is to not use a safe navigation operator in unnecessary chaining which may lead to confusion to the reader regarding the existence of the object instead use delegation.
NOTE: This is my first pr so if there is any suggestion please let me know thanks in advance :).