Merge pull request #13081 from fatkodima/zero_length_predicate-false-…

…positive Fix a false positive for `Style/ZeroLengthPredicate` when using safe navigation and non-zero comparison
rubocop · Jul 30, 2024 · 748a568 · 748a568
2 parents e1e8875 + 70d8e88
commit 748a568
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/changelog/fix_false_positive_zero_length_predicate.md b/changelog/fix_false_positive_zero_length_predicate.md
@@ -0,0 +1 @@
+* [#13081](https://github.com/rubocop/rubocop/pull/13081): Fix a false positive for `Style/ZeroLengthPredicate` when using safe navigation and non-zero comparison. ([@fatkodima][])
diff --git a/lib/rubocop/cop/style/zero_length_predicate.rb b/lib/rubocop/cop/style/zero_length_predicate.rb
@@ -47,7 +47,11 @@ def on_send(node)
           check_zero_length_comparison(node)
           check_nonzero_length_comparison(node)
         end
-        alias on_csend on_send
+
+        def on_csend(node)
+          check_zero_length_predicate(node)
+          check_zero_length_comparison(node)
+        end
 
         private
 

diff --git a/spec/rubocop/cop/style/zero_length_predicate_spec.rb b/spec/rubocop/cop/style/zero_length_predicate_spec.rb
@@ -178,14 +178,9 @@
       RUBY
     end
 
-    it 'registers an offense for `array&.length > 0`' do
-      expect_offense(<<~RUBY)
+    it 'does not register an offense for `array&.length > 0`' do
+      expect_no_offenses(<<~RUBY)
         [1, 2, 3]&.length > 0
-        ^^^^^^^^^^^^^^^^^^^^^ Use `!empty?` instead of `length > 0`.
-      RUBY
-
-      expect_correction(<<~RUBY)
-        ![1, 2, 3]&.empty?
       RUBY
     end