Merge pull request #2034 from rubocop/improve-code-coverage

Tell SimpleCov to ignore unreachable code

Author: bquorning

.simplecov

@@ -2,7 +2,7 @@
 
 SimpleCov.start do
   enable_coverage :branch
-  minimum_coverage line: 100, branch: 98.44
+  minimum_coverage line: 100, branch: 100
   add_filter '/spec/'
   add_filter '/vendor/bundle/'
 end

lib/rubocop/cop/rspec/be_nil.rb

@@ -48,6 +48,10 @@ def on_send(node)
             check_be_style(node)
           when :be_nil
             check_be_nil_style(node)
+          else
+            # :nocov:
+            :noop
+            # :nocov:
           end
         end
 

lib/rubocop/cop/rspec/example_wording.rb

@@ -128,7 +128,7 @@ def text(node)
             node.node_parts.map { |child_node| text(child_node) }.join
           when :str
             node.value
-          when :begin
+          else
             node.source
           end
         end

lib/rubocop/cop/rspec/excessive_docstring_spacing.rb

@@ -100,7 +100,7 @@ def text(node)
             node.node_parts.map { |child_node| text(child_node) }.join
           when :str, :sym
             node.value
-          when :begin
+          else
             node.source
           end
         end

lib/rubocop/cop/rspec/implicit_subject.rb

@@ -97,6 +97,7 @@ def on_send(node)
 
         private
 
+        # rubocop:disable Metrics/MethodLength
         def autocorrect(corrector, node)
           case node.method_name
           when :expect
@@ -107,8 +108,13 @@ def autocorrect(corrector, node)
             corrector.replace(node.location.selector, 'expect(subject).to')
           when :should_not
             corrector.replace(node.location.selector, 'expect(subject).not_to')
+          else
+            # :nocov:
+            :noop
+            # :nocov:
           end
         end
+        # rubocop:enable Metrics/MethodLength
 
         def message(_node)
           case style
@@ -119,6 +125,7 @@ def message(_node)
           end
         end
 
+        # rubocop:disable Metrics/MethodLength
         def invalid?(node)
           case style
           when :require_implicit
@@ -129,8 +136,13 @@ def invalid?(node)
             implicit_subject_in_non_its_and_non_single_line?(node)
           when :single_statement_only
             implicit_subject_in_non_its_and_non_single_statement?(node)
+          else
+            # :nocov:
+            :noop
+            # :nocov:
           end
         end
+        # rubocop:enable Metrics/MethodLength
 
         def implicit_subject_in_non_its?(node)
           implicit_subject?(node) && !its?(node)

lib/rubocop/cop/rspec/message_spies.rb

@@ -80,6 +80,10 @@ def error_message(receiver)
             MSG_RECEIVE
           when :have_received
             format(MSG_HAVE_RECEIVED, source: receiver.source)
+          else
+            # :nocov:
+            :noop
+            # :nocov:
           end
         end
       end

lib/rubocop/cop/rspec/predicate_matcher.rb

@@ -110,6 +110,7 @@ def rewrite_matcher(corrector, predicate, matcher)
           )
         end
 
+        # rubocop:disable Metrics/MethodLength
         def true?(to_symbol, matcher)
           result = case matcher.method_name
                    when :be, :eq, :eql, :equal
@@ -118,9 +119,14 @@ def true?(to_symbol, matcher)
                      true
                    when :be_falsey, :be_falsy, :a_falsey_value, :a_falsy_value
                      false
+                   else
+                     # :nocov:
+                     :noop
+                     # :nocov:
                    end
           to_symbol == :to ? result : !result
         end
+        # rubocop:enable Metrics/MethodLength
       end
 
       # A helper for `explicit` style
@@ -266,7 +272,7 @@ def replacement_matcher(node)
             'be(false)'
           when [false, true]
             'be_truthy'
-          when [false, false]
+          else
             'be_falsey'
           end
         end
@@ -335,6 +341,10 @@ def on_send(node)
             check_inflected(node)
           when :explicit
             check_explicit(node)
+          else
+            # :nocov:
+            :noop
+            # :nocov:
           end
         end