Move the department associated with Capybara::RSpecMatchers to Capybara/RSpec/*
#155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ydah
force-pushed
the
move-rspec-dept
branch
from
c4fe915 to
5b627ab
Compare
|
ydah
force-pushed
the
move-rspec-dept
branch
from
5b627ab to
994cf7c
Compare
|
ydah
force-pushed
the
move-rspec-dept
branch
2 times, most recently
from
7149ec9 to
22946c3
Compare
…ybara/RSpec/*` This PR move the department associated with `Capybara::RSpecMatchers` to `Capybara/RSpec/*`. `Capybara/CurrentPathExpectation`, `Capybara/SpecificMatcher`, `Capybara/NegationMatcher`, and `Capybara/VisibilityMatcher` cops depend on methods from the `Capybara::RSpecMatchers` class. https://www.rubydoc.info/gems/capybara/Capybara/RSpecMatchers
ydah
force-pushed
the
move-rspec-dept
branch
from
22946c3 to
3431346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR move the department associated with
Capybara::RSpecMatcherstoCapybara/RSpec/*.Capybara/CurrentPathExpectation,Capybara/SpecificMatcher,Capybara/NegationMatcher, andCapybara/VisibilityMatchercops depend on methods from theCapybara::RSpecMatchersclass.https://www.rubydoc.info/gems/capybara/Capybara/RSpecMatchers
Replace this text with a summary of the changes in your PR. The more detailed you are, the better.
Before submitting the PR make sure the following are checked:
main(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have modified an existing cop's configuration options:
VersionChanged: "<<next>>"inconfig/default.yml.