Skip to content

Commit eefb72a

Browse files
committed
Add new "Prefer all_(day|week|month|quarter|year) over range of date/time" rule
Follow up rubocop/rubocop-rails#730. This PR adds new "Prefer `all_(day|week|month|quarter|year)` over range of date/time" rule. ```ruby # bad date.beginning_of_day..date.end_of_day date.beginning_of_week..date.end_of_week date.beginning_of_month..date.end_of_month date.beginning_of_quarter..date.end_of_quarter date.beginning_of_year..date.end_of_year # good date.all_day date.all_week date.all_month date.all_quarter date.all_year ```
1 parent 43a9832 commit eefb72a

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

README.adoc

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1723,6 +1723,28 @@ Time.zone.now # => Fri, 12 Mar 2014 22:04:47 EET +02:00
17231723
Time.current # Same thing but shorter.
17241724
----
17251725

1726+
=== Prefer `all_(day|week|month|quarter|year)` over range of date/time [[date-time-range]]
1727+
1728+
Prefer `all_(day|week|month|quarter|year)` over `beginning_of_(day|week|month|quarter|year)..end_of_(day|week|month|quarter|year)`
1729+
to get the range of date/time.
1730+
1731+
[source,ruby]
1732+
----
1733+
# bad
1734+
date.beginning_of_day..date.end_of_day
1735+
date.beginning_of_week..date.end_of_week
1736+
date.beginning_of_month..date.end_of_month
1737+
date.beginning_of_quarter..date.end_of_quarter
1738+
date.beginning_of_year..date.end_of_year
1739+
1740+
# good
1741+
date.all_day
1742+
date.all_week
1743+
date.all_month
1744+
date.all_quarter
1745+
date.all_year
1746+
----
1747+
17261748
== Duration
17271749

17281750
=== Duration Application

0 commit comments

Comments
 (0)