-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create VSIX package with support for VS2017 #57
Comments
In case you haven't seen the error that's thrown when trying to do an install in VS2017 RC: 2/10/2017 4:30:40 PM - Microsoft VSIX Installer |
MSVC 2017 is now officially released. Any update on the packaging? |
Soonish, but I can't promise this week. |
Hi guys! I'm sorry, we're still stuck on getting the release packages signed and uploaded to the Visual Studio gallery. In the meantime, I've attached the unsigned packages to the GitHub release information: |
I installed the 2.0.0 pre-release to VS 2017 community and it's giving an error upon load: http://i.mechacrash.com/8RAffD5g.png I compiled the source myself prior but was also getting issues (the extension simply did nothing) but assumed it was a fault on my part. |
It installs for me, but it doesn't automatically add a header to new files. In fact, if you manually right-click a filename and select "Add License Header" then Visual Studio creates a very helpful dialog box with The only errors in the ActivityLog.xml: (Full log)
Microsoft Visual Studio Community 2017 |
Hmm...It works with my VS 2017 Enterprise Edition and I think we also tested the Community Edition but @FlorianDecker would have to answer that one. There's nothing obvious in the VS2017 compability changeset that would indicate a duplicate ID. This will require further testing. Could you please create a separate issue for this? |
@mechacrash i was able to reproduce your error with a fresh VS2017 , just not consistently. When i got the error and restarted VS, the LicenseHeaderManager worked without problems and the error did not appear again. Can you confirm this behaviour, or is the LicenseHeaderManager extension never loaded? @Convery i could not reproduce your error and i am not sure if it is really an error produced by the VS2017 compatibility. Do you have other Visual Studio versions installed where you could test if the LicenseHeaderManager works correctly (with the same file)? As i dont think this is due to the VS2017 compatibility, we should move this discussion to #68 |
When I tested, nothing worked. I attempted to start up VS multiple time and the extension never loaded. The activity log was always the same. |
@mechacrash hmhh, as it worked with my fresh VS2017 Community, i can think of two possible causes:
Path should be something like
|
As we have VS2017 compatibility for a while now, i am closing this issue. If there are still problems with the installation, please open a new issue. |
@mechacrash #84 had the same issue as you i think. Please try out this unsigned version, it should fix the issue with the extension not loading. |
VS2017 requires a VSIX package that specifies the features used.
Note that VSIX packages created with VS2017 are backwards compatible down to VS2012. The current version still supports VS2010. We will need to provide a separate installer vor VS2010.
https://www.visualstudio.com/en-us/news/releasenotes/vs2017-relnotes#vside
The text was updated successfully, but these errors were encountered: