Skip to content

Log applied migration id #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

tamalsaha
Copy link

No description provided.

@rubenv
Copy link
Owner

rubenv commented Sep 30, 2016

I won't merge this: sql-migrate can be used as a library, where log output may not be desired.

@rubenv rubenv closed this Sep 30, 2016
@tamalsaha
Copy link
Author

@rubenv, understood. We are using this as a lib. Having no logging was causing us to wonder when things failed. May there can be verbose option with default false to preserve current behavior.

@rubenv
Copy link
Owner

rubenv commented Sep 30, 2016

@tamalsaha What went wrong should be present in the error returned by Exec(), no?

@tamalsaha
Copy link
Author

In our case, nothing went wrong, but it was also doing nothing. Sort of got stuck. We don't know what happened yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants