Skip to content

Commit df3055c

Browse files
authored
Unify idl and use new annotations (#270)
* Github issue: #270 * Pull request: #271
2 parents 5942b83 + 6b7019f commit df3055c

File tree

3 files changed

+32
-9
lines changed

3 files changed

+32
-9
lines changed

srcDoc/release_notes.rst

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,15 @@ The combination of the previous issue and a bug in *RTI Connext DDS Micro*
190190
(MICRO-2191), would cause that the LatencyTopic endpoints were not correctly
191191
discovered in certain cases, making impossible to gather Latency Numbers.
192192

193+
Update the idl to use prefix annotations (#270)
194+
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
195+
196+
In previous versions, *RTI Perftest* idls used a combination of the new
197+
prefix annotations and the old ones. This inconsistency has been fixed.
198+
199+
This imposes a restriction (already existing) in the minimum version for which
200+
*RTI Perftest* can be compiled to *RTI Connext DDS Professional* 5.3.1.
201+
193202
Release Notes 3.0
194203
-----------------
195204

srcIdl/perftest.idl

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,17 @@ const string THROUGHPUT_TOPIC_NAME = "Throughput";
2424
const string LATENCY_TOPIC_NAME = "Latency";
2525
const string ANNOUNCEMENT_TOPIC_NAME = "Announcement";
2626

27+
/*
28+
* This idl uses prefix annotations. In order to compile with previous versions
29+
* of *Connext DDS Professional* modify the following annotations:
30+
*
31+
* - @final -- Remove it and replace at the
32+
* end with "//@Extensibility FINAL_EXTENSIBILITY"
33+
* - @key -- Remove it and replace it at the end of the member with "//@key"
34+
*
35+
*/
36+
37+
@final
2738
struct TestData_t {
2839
octet key[KEY_SIZE];
2940

@@ -40,8 +51,9 @@ struct TestData_t {
4051
long custom_type_size;
4152
#endif
4253

43-
}; //@Extensibility FINAL_EXTENSIBILITY
54+
};
4455

56+
@final
4557
struct TestDataKeyed_t {
4658
@key
4759
octet key[KEY_SIZE];
@@ -57,8 +69,9 @@ struct TestDataKeyed_t {
5769
RTI_CUSTOM_TYPE custom_type;
5870
long custom_type_size;
5971
#endif
60-
}; //@Extensibility FINAL_EXTENSIBILITY
72+
};
6173

74+
@final
6275
struct TestDataLarge_t {
6376
octet key[KEY_SIZE];
6477

@@ -72,8 +85,9 @@ struct TestDataLarge_t {
7285
RTI_CUSTOM_TYPE custom_type;
7386
long custom_type_size;
7487
#endif
75-
}; //@Extensibility FINAL_EXTENSIBILITY
88+
};
7689

90+
@final
7791
struct TestDataKeyedLarge_t {
7892
@key
7993
octet key[KEY_SIZE];
@@ -89,12 +103,11 @@ struct TestDataKeyedLarge_t {
89103
RTI_CUSTOM_TYPE custom_type;
90104
long custom_type_size;
91105
#endif
92-
}; //@Extensibility FINAL_EXTENSIBILITY
106+
};
93107

108+
/********************************** FLATDATA **********************************/
94109
#ifdef RTI_FLATDATA_AVAILABLE
95-
/*
96-
* FLATDATA
97-
*/
110+
98111
@mutable
99112
@language_binding(FLAT_DATA)
100113
struct TestData_FlatData_t {
@@ -168,4 +181,5 @@ struct TestDataKeyedLarge_FlatData_t {
168181
long custom_type_size;
169182
#endif
170183
};
171-
#endif // RTI_FLATDATA_AVAILABLE
184+
185+
#endif // RTI_FLATDATA_AVAILABLE

srcIdl/perftest_ZeroCopy.idl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,4 +95,4 @@ struct TestDataKeyedLarge_ZeroCopy_w_FlatData_t {
9595
RTI_CUSTOM_TYPE_FLATDATA custom_type;
9696
long custom_type_size;
9797
#endif
98-
};
98+
};

0 commit comments

Comments
 (0)