This repository was archived by the owner on Oct 27, 2020. It is now read-only.
plugin compatibility with the gitbook 2.0.1 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@todvora Thanks for PR. :-) I am aware of the issue - #3 I also posted about it here - GitbookIO/gitbook#724 I will merge this PR and update readme notes from here #3 (comment) and also add more details. |
rahul286
added a commit
that referenced
this pull request
Apr 28, 2015
plugin compatibility with the gitbook 2.0.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made some changes in the hook and adapted it to the gitbook 2.0.1. This should solve the issue #3. It uses the
pagehook. The generated edit link is inserted directly into the page and later moved byplugin.jsback to the menu bar. Gitbook still says, thatwarn: hook 'page' used by plugin 'gitbook-plugin-edit-link' is deprecated, and will be remove in the coming versions, but lots of plugins depend on this hook and I hope it will be available also in next releases.Could you please review and test the code on your setup? In the readme you don't mention any release/compatibility guidelines and I am not sure, how much backwards compatible my code is.
I tested this PR in single and multilanguage book setups and it seems to work fine. But one never knows.
Best regards,
Tomas