Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated JooYoung's info #438

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Updated JooYoung's info #438

merged 2 commits into from
Sep 9, 2021

Conversation

jooyoungseo
Copy link

Thanks for your final touch, @cderv! This PR updates my information (e.g., email; affiliation) following #251.

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jooyoungseo
❌ JooYoung Seo


JooYoung Seo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I agree that DESCRIPTION should be updated. However, maybe we should not put your information into the skeleton Rmd so that your information are not left in all template document created and we do not have to update them while they change.

Don't you think ?

@jooyoungseo
Copy link
Author

Agreed, @cderv! I will update the default skeleton author info following the original template by tomorrow.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@cderv cderv merged commit 2e0a3d0 into rstudio:master Sep 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants