Conversation
There was a problem hiding this comment.
-
Please rebase against the current master branch, and force push.
-
Please add
-
yourself to the list of authors: https://github.com/rstudio/rticles/blob/master/DESCRIPTION
-
an entry in NEWS about the new format (under v0.5) and an entry in README.md.
-
a test to https://github.com/rstudio/rticles/blob/master/tests/testit/test-formats.R
-
Thanks!
yihui
force-pushed
the
master
branch
3 times, most recently
from
8023cbf to
928d6cd
Compare
At the request of @yihui in rstudio#170
|
My fork has been rebased and force pushed. I have added myself to the list of authors, update README.md, and added a test. |
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Excellent. With two possible minor changes, I think we are ready to go!
BTW, did you sign the contributor agreement? https://github.com/rstudio/rticles/blob/master/.github/PULL_REQUEST_TEMPLATE.md
NEWS
Outdated
|
|
||
| - Added the template for the SAGE Journals (thanks, @oguzhanogreden, #181). | ||
|
|
||
| - Added the template for Biometrics (@daltonhance, #170) |
There was a problem hiding this comment.
Could you also add an entry in README.md?
R/biometrics_article.R
Outdated
| #' } | ||
| #' | ||
| #' @export | ||
| biometrics_article <- function(..., keep_tex = TRUE, citation_package = 'none'){ |
There was a problem hiding this comment.
Are you sure you don't want to set citation_package = 'natbib' as the default?
…for tightlist. Changed default citation_package to natbib to match template.
|
I just sent my contributor agreement off. I changed the default citation_package to natbib. I did add a link to the Biometrics journal on the README.md on my fork. |
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Great! We can merge this PR once @jjallaire confirms on the CLA. Thank you very much!
2 participants
This creates a template for a submission to Biometrics based off the journal LaTeX class. There is still some housekeeping in terms of creating a helpfile and exporting the namespace, but I've tested it on my machine.
Apologies for any poor Github etiquette, this is my first external pull request.