docs: Replace {sp} with {sf} in pkgdown site; Fix a handful of broken examples #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
reviewed
Aug 7, 2024
schloerke
reviewed
Aug 7, 2024
schloerke
reviewed
Aug 7, 2024
schloerke
approved these changes
Aug 7, 2024
|
Thank you!! |
schloerke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #909.
In short:
Use of
{sp}in all instances has been replaced with{sf}.A small mention is made on back-compatibility with
{sp}, but steers users towards the modern approach which is{sf}.Replaces the broken examples in https://rstudio.github.io/leaflet/articles/projections.html and https://rstudio.github.io/leaflet/articles/shapes.html#simplifying-complex-polygonspolylines, which both use the archived
{albersusa}package, with data from{rnaturalearth}. This package is now "Suggested" to make the vignettes run correctly.Fixes the broken example in https://rstudio.github.io/leaflet/articles/markers.html#icon-markers which refers to local files which no longer exist. URLS now point to Wikimedia, which makes them load properly!
Minor spelling/grammar fixes.