Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only trigger deploy to Netlify from main branch #179

Open
jspiewak opened this issue Apr 22, 2022 · 4 comments
Open

Only trigger deploy to Netlify from main branch #179

jspiewak opened this issue Apr 22, 2022 · 4 comments

Comments

@jspiewak
Copy link
Member

The Netlify step appears to run on every change, regardless of branch, resulting in no-op deployments in Netlify.
Should it have if: github.ref == 'refs/heads/main' as a guard clause like the GitHub deploy?

https://github.com/rstudio/ai-blog/blob/main/.github/workflows/main.yml#L93

@skeydan
Copy link
Contributor

skeydan commented Apr 22, 2022

Hi Josh,

no, it shouldn't result in no-op deployments ... for every preview triggered, I got notified about deployment locations that look like this:

https://6262b882578849340255bc1c--hardcore-kirch-782335.netlify.app/

For us, it is important to be able to preview posts after individual changes have been made, so we can see if something breaks the layout, a picture renders nicely, etc.

Of course, the posts are written offline at first, but before deployment, some changes will have to be made (for example, due to review comments).

@jspiewak
Copy link
Member Author

harcore-kirch isn't an rstudio Netlify site.
What I am referring to is the triggering of a Netlify build of reverent-jones-333de8, which is the meta-blog site. Those are no ops because it only builds main.

@jspiewak
Copy link
Member Author

Should hardcore-kirch be transferred to the rstudio Netlify team?

@skeydan
Copy link
Contributor

skeydan commented Apr 22, 2022

That sounds great, thank you very much! Honestly I don't even have access - Netlify was managed by Javier before he left ...
If the RStudio team could take care of it that'd be awesome ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants